Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add node_module_version to config.gypi #7808

Closed
wants to merge 2 commits into from
Closed

build: add node_module_version to config.gypi #7808

wants to merge 2 commits into from

Commits on Jun 23, 2016

  1. build: turn on -fno-delete-null-pointer-checks 

    Work around spec violations in V8 where it checks that `this == NULL`.
GCC 6 started exploiting this particular kind of UB, resulting in
runtime crashes.

Fixes: nodejs#6724
PR-URL: nodejs#6738
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
    @bnoordhuis @rvagg
    bnoordhuis authored and rvagg committed Jun 23, 2016
    Configuration menu
    Copy the full SHA
    7f44ecf View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2016

  1. build: add node_module_version to config.gypi 

    Enable targetting of a different node version than
the currently running one when building binary modules.

Based on nodejs/node@410296c37

PR-URL: nodejs#7808
Ref: nodejs/node-gyp#855
    @saper
    saper committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    6a47a07 View commit details
    Browse the repository at this point in the history