test: avoid IPv6 hostname conflict in windows #7869
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test case test/gc/test-net-timeout.js fails in Windows due to the mixed-use of unspecified and loopback addresses. This is not a problem in most platforms but fails in Windows. A detailed test report describes the platform differences (#7728) and the general direction suggested is to fix the tests according to their platform specific requirements
mscdex
added
net
|
@gireeshpunathil FYI #7781 , judging from #7781 (comment) it looks like there might be other issues with this test that need fixing. |
|
@nodejs/testing @nodejs/platform-windows |
rvagg
force-pushed
the
master
branch
2 times, most recently
from
c133999 to
83c7a88
Compare
3 tasks
|
Should be fixed by #10854, feel free to reopen if that isn't the case! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
windows, cluster
Description of change
The test case test/gc/test-net-timeout.js
fails in Windows due to the mixed-use of unspecified
and loopback addresses. This is not a problem in most
platforms but fails in Windows.
A detailed test report describes the platform differences
(#7728)
and the general direction suggested is to fix the tests
according to their platform specific requirements