doc: add missing windowsVerbatimArguments option in child_process.spawn

[stevemao]

Checklist

• make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

Windows

Description of change

Just documentation change for windowsVerbatimArguments option in child_process.spawn

/cc @nodejs/documentation @SetTrend

Fixes #5060

[mscdex]

This is actually only adding it to the documentation for .fork(). Technically if it's going to be added, it should be added to all of the methods.

[cjihrig]

All of the methods except exec() and execSync() should specify that the default is false. exec() and execSync() unconditionally set this to true on Windows, and false otherwise.

[garthk]

@cjihrig what's the mechanism for "unconditionally set this to true"? In 99f45b2 I see exec call normalizeExecArgs, which passes options objects through without touching windowsVerbatimArguments, then execFile, which coerces its options. windowsVerbatimArguments to a boolean, i.e. false unless given.

[cjihrig]

normalizeExecArgs(), which is only called from exec() and execSync(), sets the shell option. normalizeSpawnArguments() detects the shell option, and on Windows sets windowsVerbatimArguments to true.

[garthk]

Aah, got it. Thanks.

[MylesBorins]

@stevemao do you still want to run with this? if not we should make it a good first contribution

[fhinkel]

ping @stevemao

[jasnell]

Closing due to lack of forward progress. We can reopen if necessary