-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: removing unused StringValue macro parameters #7905
src: removing unused StringValue macro parameters #7905
Conversation
The reason I left that in is so you don't have to go searching for the type of the second parameter. |
Sorry if I'm misunderstanding you here. When I was reading the code I was looking for usage of StringValue, but could not find any (in the places covered by this PR I mean), despite the I'm happy to have this PR closed as I just wanted to raise this in case it was something that was overlooked. |
What I mean is that calling it 'ignored' means you have to go hunting for the PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES define if you want to know what the type of the second argument is, that's why I gave it a name that conveys that information (and also for consistency with other places where that macro is used.) |
Ah I see, thanks for clarifying. I'll change it back to |
Currently, there are a few places where macro functions passed to the PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES and PER_ISOLATE_STRING_PROPERTIES macros, don't use the StringValue parameter. This commit removes the StringValue parameter where it is not used.
f4e38f3
to
c7b3871
Compare
Sorry, I forgot about this PR. I've rebased it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, CI looks good
Currently, there are a few places where macro functions passed to the PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES and PER_ISOLATE_STRING_PROPERTIES macros, don't use the StringValue parameter. This commit removes the StringValue parameter where it is not used. PR-URL: nodejs#7905 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Thanks for the reviews! Landed in: 84eaa4a |
Currently, there are a few places where macro functions passed to the PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES and PER_ISOLATE_STRING_PROPERTIES macros, don't use the StringValue parameter. This commit removes the StringValue parameter where it is not used. PR-URL: #7905 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
resolves to an empty commit on v6 |
Checklist
make -j4 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
src
Description of change
Currently, there are a few places where macro functions passed to the
PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES and
PER_ISOLATE_STRING_PROPERTIES macros, don't use the StringValue parameter.
This commit removes the StringValue parameter where it is not used.