doc: typo added missing semicolons #7911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing semicolons to some places on the assert.mardown
|
LGTM |
|
Are you sure this applies only to v4.x and not the master branch? Typically almost all changes happen in master first, then they get backported as necessary. |
|
I was reading the doc for assert module for v4.x branch and then found missing semicolons in some examples and thought to open pull request. |
|
The first two changes were fixed recently in master with #7745. I have marked that PR for backporting. The last change is still missing in master though, would you mind instead opening a PR against master to fix that particular line? Then we can backport that as well. |
|
Sure! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Added missing semicolons to some missing places on the assert.mardown