Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix dependency on missing header file #7945

Merged
merged 2 commits into from
Aug 3, 2016
Merged

build: fix dependency on missing header file #7945

merged 2 commits into from
Aug 3, 2016

Commits on Aug 3, 2016

  1. build: fix typo in non-essential source file name 

    Depend on src/inspector_agent.h, src/inspector-agent.h does not exist.

The typo didn't break the build but it made some of the gyp-based
tooling complain.

PR-URL: nodejs#7945
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
    @bnoordhuis
    bnoordhuis committed Aug 3, 2016
    Configuration menu
    Copy the full SHA
    c0676f3 View commit details
    Browse the repository at this point in the history

  2. build: fix dependency on missing header file 

    Depend on include/ares_rules.h, src/ares_rules.h does not exist.

The typo didn't break the build but it made some of the gyp-based
tooling complain.

PR-URL: nodejs#7945
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
    @bnoordhuis
    bnoordhuis committed Aug 3, 2016
    Configuration menu
    Copy the full SHA
    05c15a0 View commit details
    Browse the repository at this point in the history