Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: hard-deprecate SlowBuffer #8182

Closed
wants to merge 1 commit into from
Closed

buffer: hard-deprecate SlowBuffer #8182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,16 @@ Buffer.allocUnsafeSlow = function(size) {

// If --zero-fill-buffers command line argument is set, a zero-filled
// buffer is returned.
var slowBufferWarned = false;
function SlowBuffer(length) {
if (!slowBufferWarned) {
slowBufferWarned = true;
process.emitWarning(
'SlowBuffer is deprecated. ' +
'Use `Buffer.alloc()` or `Buffer.allocUnsafeSlow()` instead.'
Copy link
Member

@jasnell jasnell Aug 19, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would need a second argument set to 'DeprecationWarning'... that is:

process.emitWarning(
  'SlowBuffer is deprecated. ' +
  'Use `Buffer.alloc()` or `Buffer.allocUnsafeSlow()` instead.',
  'DeprecationWarning');

);
}

if (+length != length)
length = 0;
return createUnsafeBuffer(+length);
Expand Down