Skip to content

Conversation

@shaikh-shahid
Copy link
Contributor

@shaikh-shahid shaikh-shahid commented Aug 19, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@nodejs-github-bot nodejs-github-bot added util Issues and PRs related to the built-in util module. doc Issues and PRs related to the documentations. labels Aug 19, 2016
doc/api/util.md Outdated

ES6 example using class and extends

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code class js or es6 is missing?

@jasnell
Copy link
Member

jasnell commented Aug 19, 2016

LGTM /cc @nodejs/documentation

@yorkie
Copy link
Contributor

yorkie commented Aug 20, 2016

LGTM

1 similar comment
@eljefedelrodeodeljefe
Copy link
Contributor

LGTM

jasnell pushed a commit that referenced this pull request Aug 21, 2016
Added class/extends example to util.md

PR-URL: #8183
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
@jasnell
Copy link
Member

jasnell commented Aug 21, 2016

Landed in 9a91ffb! thank you!
I did fix up the commit message to follow our contribution guide.

@jasnell jasnell closed this Aug 21, 2016
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
Added class/extends example to util.md

PR-URL: #8183
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants