Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: keep auth in url.resolve() if host matches #8215

Closed
wants to merge 1 commit into from
Closed

url: keep auth in url.resolve() if host matches #8215

wants to merge 1 commit into from

Conversation

imyller
Copy link
Member

@imyller imyller commented Aug 21, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

url

Description of change

Keep auth in URL if host and hostname is not changed.

Fixes regression introduced in PR #1480

Fixes: #8165

@nodejs-github-bot nodejs-github-bot added the url Issues and PRs related to the legacy built-in url module. label Aug 21, 2016
@jasnell
Copy link
Member

jasnell commented Aug 22, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/3791/

@jasnell
Copy link
Member

jasnell commented Aug 22, 2016

LGTM if CI is green

@jasnell
Copy link
Member

jasnell commented Aug 23, 2016

New CI: https://ci.nodejs.org/job/node-test-pull-request/3805/
red in the last run is most likely unrelated but just in case...

@jasnell
Copy link
Member

jasnell commented Aug 23, 2016

CI failures are unrelated. Landing...

@jasnell
Copy link
Member

jasnell commented Aug 23, 2016

ugh.. nevermind... @imyller... can you rebase this really quick?

@imyller
url: keep auth in url.resolve() if host matches
aaae94e 
Fixes: nodejs#8165

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
@imyller
Copy link
Member Author

imyller commented Aug 24, 2016

@jasnell rebased

@jasnell
Copy link
Member

jasnell commented Aug 24, 2016

New CI after rebase: https://ci.nodejs.org/job/node-test-pull-request/3822/

jasnell pushed a commit that referenced this pull request Aug 24, 2016
@imyller @jasnell
url: keep auth in url.resolve() if host matches
51f96df 
Fixes: #8165

PR-URL: #8215
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Aug 24, 2016

Landed in 51f96df. Thank you!

@jasnell jasnell closed this Aug 24, 2016
@msakrejda msakrejda mentioned this pull request Aug 31, 2016
Closed
@Fishrock123 Fishrock123 mentioned this pull request Sep 6, 2016
Closed
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Sep 8, 2016
@imyller @Fishrock123
url: keep auth in url.resolve() if host matches
7307367 
Fixes: nodejs#8165

PR-URL: nodejs#8215
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Sep 9, 2016
@imyller @Fishrock123
url: keep auth in url.resolve() if host matches
6ae7af0 
Fixes: #8165

PR-URL: #8215
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

MylesBorins commented Sep 30, 2016 •
edited
Loading

adding a don't land tag as this appears to be related to a semver major change not found on v4.x

Please feel free to change the label if I am mistaken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

url.resolve auth behavior if host does *not* change
4 participants
@imyller @jasnell @MylesBorins @nodejs-github-bot