test: add known issue test for path parse issue #6229 #8293
Conversation
| const assert = require('assert'); | ||
| const path = require('path'); | ||
|
|
||
| // Issue: https://github.com/nodejs/node/issues/6229 |
There was a problem hiding this comment.
Could you move this to the top, just under 'use strict;', and change Issue to Refs for consistency with the other known issue tests.
|
LGTM with a comment. |
|
Done. Also renamed the test file to be more specific. |
|
Nit: Two tests in the file, one for Nit: Instead of asserting that the two results are not equal, maybe make the test a bit more strict by asserting that each one equals exactly what it is supposed to equal? assert.strictEqual(parsed1, {root: '/', dir: '/foo', base: 'bar', ext: '', name: 'bar'});
assert.strictEqual(parsed2, {root: '/', dir: '/foo/bar', base: '', ext: '', name: ''});If you're concerned that maybe we'll add another key to the object, you could do assertions specifically for the |
|
Updated. |
|
LGTM |
|
Landed in 407069a |
Refs: nodejs#6229 PR-URL: nodejs#8293 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
ghost
mentioned this pull request
|
@jasnell backport to v4x? |
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
known_issue
Description of change
Add known_issue test for #6229