Improving code readability on lib/_http_agent.js #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if (freeLen) { | ||
| if (avaliableFreeSockets) { |
There was a problem hiding this comment.
typo: avaliableFreeSockets -> availableFreeSockets
There was a problem hiding this comment.
it's done consistently though, haha ^^
imjacobclark
changed the title
| // we have a free socket, so use that. | ||
| var socket = this.freeSockets[name].shift(); | ||
| debug('have free socket'); | ||
|
|
||
| var hasFreeSockets = !this.freeSockets[name].length |
There was a problem hiding this comment.
Could this be accomplished with a comment rather than creating another var to keep track of? I find the // don't leak to be more sloppy than this particular change.
I don't like this pattern... but I applaud the effort of improving readability and variable naming as you have above. 👍
|
Closing as the discussion in #60 is ongoing on how to tackle this. |
boingoing
pushed a commit
to boingoing/node
that referenced
this pull request
Apr 6, 2017
- Make string API names consistent - Make string API coercion behavior consistent - Switch from number-remaining to number-copied results - Add UTF-16 string APIs - Add coercion APIs for number and bool - Update tests for API changes
forivall
pushed a commit
to forivall/node
that referenced
this pull request
Oct 7, 2017
[ci skip] PR-URL: ayojs/ayo#83 Reviewed-By: Jan Lehnardt <jan@apache.org> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James Butler <james.butler@sandfox.co.uk> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Alex <alex@dytry.ch> Reviewed-By: <agentantelope+github@gmail.com> Reviewed-By: olivia <olivia@fastmail.com> Reviewed-By: srilq <git@srilq.email> Reviewed-By: Scott Trinh <scott@scotttrinh.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per proposal #60, I have begun cleaning the code to create a more readable codebase.
I feel, and hope others agree, this will allow a more diverse and wider community to begin contributing and collaborating with io.js, reducing the learning curve and amount of developer documentation required for the codebase, equally making it easier to test and understand what is going on under the hook.
I will continue to clean the codebase into a self documenting one where possible, and encourage others to do the same.