-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add .md to the link #8315
doc: add .md to the link #8315
Conversation
fix a wrong link to ../topics/the-event-loop-timers-and-nexttick.md
Looks good to me! Could you amend the commit message so that it starts with |
@Alexis374 Looks like you only changed the PR title, not the actual commit. To amend the commit message, you'll need a local clone of your github fork on node. Then:
|
LGTM with the commit log fix. |
fix a wrong link to ../topics/the-event-loop-timers-and-nexttick.md
@addaleax @Fishrock123 I did as you told, please check whether I did sth wrong. |
@Alexis374 it looks like there’s a (nobody is claiming that git is easy to work with… :/) |
fix a wrong link to ../topics/the-event-loop-timers-and-nexttick.md PR-URL: #8315 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
fix a wrong link to ../topics/the-event-loop-timers-and-nexttick.md PR-URL: nodejs#8315 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
fix a wrong link to ../topics/the-event-loop-timers-and-nexttick.md PR-URL: #8315 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Checklist
make -j4 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
Description of change
fix a wrong link to ../topics/the-event-loop-timers-and-nexttick.md