test: refactor parallel/test-process-env.js #8324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
test
|
LGTM |
1 similar comment
|
LGTM |
|
CI, although Raspberry Pi issues abound at the moment. Will almost certainly need to re-run. But just to suss out anything that might be lurking elsewhere. CI: https://ci.nodejs.org/job/node-test-pull-request/3898/ |
|
Looks like the test that was commented out fails on AIX and Windows. I'll comment it out again. It may make sense to skip it only on those platforms, but I'd want something like that to happen in a separate PR, I think. |
* Remove disabling of lint rule * Enable commented-out test * == -> === * var -> const
Trott
force-pushed
the
refactor-test-process-env
branch
from
6915a2e to
4fd2578
Compare
|
CI passed. (Yellow because of AIX perma-yellow right now.) |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 31, 2016
* Remove disabling of lint rule * == -> === * var -> const PR-URL: nodejs#8324 Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
|
Landed in 266270e |
Closed
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Sep 8, 2016
* Remove disabling of lint rule * == -> === * var -> const PR-URL: nodejs#8324 Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Sep 9, 2016
* Remove disabling of lint rule * == -> === * var -> const PR-URL: #8324 Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test process
Description of change
==->===var->const