doc: fix example in stream doc #8378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Fix cases where `chunk` is a buffer. PR-URL: nodejs#8378 Fixes: nodejs#8085
| chunk = chunk.toString(encoding); | ||
| this[kSource].writeSomeData(chunk, encoding); | ||
| chunk = chunk.toString(); | ||
| this[kSource].writeSomeData(chunk); |
There was a problem hiding this comment.
The assumption here is that encoding is optional.
|
LGTM. I’ll start landing this:
|
|
Landed in 7f71419 |
geek
pushed a commit
to geek/node
that referenced
this pull request
Sep 30, 2016
Fix cases where `chunk` is a buffer. PR-URL: nodejs#8378 Fixes: nodejs#8085 Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
If
chunkis a bufferchunk.toString(encoding)throws an error as'buffer'is not a valid encoding. This fixes the documentation bug by not using theencodingargument.Fixes: #8085