doc: update BUILDING.md #8398
Closed
doc: update BUILDING.md #8398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* General copy-editing * Move `[sudo] make install` step from general Unix build to own step * Remove `make test-addons` as that is now covered by `make test` * Standardize on `/path/to/foo` as used elsewhere in the doc * Change `node -e` to `./node -e` to avoid using different node binary
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Sep 6, 2016
* General copy-editing * Move `[sudo] make install` step from general Unix build to own step * Remove `make test-addons` as that is now covered by `make test` * Standardize on `/path/to/foo` as used elsewhere in the doc * Change `node -e` to `./node -e` to avoid using different node binary PR-URL: nodejs#8398 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 30dbc9d |
Fishrock123
pushed a commit
that referenced
this pull request
Sep 14, 2016
* General copy-editing * Move `[sudo] make install` step from general Unix build to own step * Remove `make test-addons` as that is now covered by `make test` * Standardize on `/path/to/foo` as used elsewhere in the doc * Change `node -e` to `./node -e` to avoid using different node binary PR-URL: #8398 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
[sudo] make installstep from general Unix build to own stepmake test-addonsas that is now covered bymake test/path/to/fooas used elsewhere in the docnode -eto./node -eto avoid using different node binary