doc: clarify sentence in event loop doc #8400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
force-pushed
the
clarify/sentence
branch
from
2a702a0 to
dbe671a
Compare
|
LGTM |
1 similar comment
|
LGTM |
| * **check**: `setImmediate()` callbacks are invoked here | ||
| * **close callbacks**: e.g socket.on('close', ...) | ||
| * **I/O callbacks**: executes almost all callbacks with the exception of | ||
| close callbacks, the ones scheduled by timers and `setImmediate()`. |
There was a problem hiding this comment.
I'd prefer a comma before and. That's consistent with the title.
|
LGTM with tiny, tiny comment. |
lpinca
force-pushed
the
clarify/sentence
branch
from
dbe671a to
485ea47
Compare
jasnell
pushed a commit
that referenced
this pull request
Sep 9, 2016
Refs: #8370 (diff) PR-URL: #8400 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
|
Landed in 88ed3d2 |
Fishrock123
pushed a commit
that referenced
this pull request
Sep 14, 2016
Refs: #8370 (diff) PR-URL: #8400 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This was referenced Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Ref: #8370 (diff)