Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: test-stdio-closed troubleshooting #8414

Closed
wants to merge 6 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 6, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@Trott Trott added the wip Issues and PRs that are still a work in progress. label Sep 6, 2016
@mscdex mscdex added test Issues and PRs related to the tests. process Issues and PRs related to the process subsystem. labels Sep 6, 2016
ABORT();
open("/dev/null", O_RDWR);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make sure that this open return current loop fd (STDIN_FILENO, STDOUT_FILENO, STDERR_FILENO).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. Yes, no doubt. This is not intended to be merged. That's what the WIP (work in progress) and the in progress label are meant to indicate. Trying some non-intuitive (and quite possibly ignorant) things to try to figure out why this bit of code seems to be not working (or perhaps the associated test is what is not working) on AIX but working on all the other POSIX systems we test on.

Copy link

@veshboo veshboo Sep 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this related to "AIX: parallel/test-stdio-closed #8375".

On AIX, I remember that there is a kernel parameter regarding max number of pseudo terminals allowed in the system. I suspect the issue is somehow related to the kernel parameter. Need to check the "errno" when the test fails.

EDIT: seems not directly related to pty because the path to open is "/dev/null".

process.exit(41);
});

process.stderr.on('err', (err) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'error'?

@Trott
Copy link
Member Author

Trott commented Sep 6, 2016

Closing for now.

@Trott Trott closed this Sep 6, 2016
@Trott
Copy link
Member Author

Trott commented Sep 7, 2016

Reopening for more troubleshooting-in-public, not something I actually recommend. Nothing to see here folks...

@Trott
Copy link
Member Author

Trott commented Sep 7, 2016

Well, that didn't work, guess I pushed before re-opening or something, on well...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests. wip Issues and PRs that are still a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants