Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix unused-result warning #8450

Merged
merged 1 commit into from
Sep 9, 2016
Merged

src: fix unused-result warning #8450

merged 1 commit into from
Sep 9, 2016

Conversation

santigimeno
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

c++

Description of change

I was getting these warnings on OS X locally:

../src/node_util.cc:138:43: warning: ignoring return value of function declared with warn_unused_result attribute [-Wunused-result]
    PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES(V)
                                          ^~
../src/env.h:56:3: note: expanded from macro 'PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES'
  V(alpn_buffer_private_symbol, "node:alpnBuffer")                            \
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/node_util.cc:133:3: note: expanded from macro 'V'
  target->Set(context,                                                        \
  ^~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/node_util.cc:138:43: warning: ignoring return value of function declared with warn_unused_result attribute [-Wunused-result]
    PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES(V)
                                          ^~
../src/env.h:57:3: note: expanded from macro 'PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES'
  V(arrow_message_private_symbol, "node:arrowMessage")                        \
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/node_util.cc:133:3: note: expanded from macro 'V'
  target->Set(context,                                                        \

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 8, 2016
@jasnell
Copy link
Member

jasnell commented Sep 8, 2016

LGTM

@addaleax
Copy link
Member

addaleax commented Sep 8, 2016

LGTM, CI: https://ci.nodejs.org/job/node-test-commit/4959/

@Trott
Copy link
Member

Trott commented Sep 8, 2016

CI failures are one known flaky on Linux and one apparent CI infra failure on Raspberry Pi. Seemingly unrelated to this change.

@bnoordhuis
Copy link
Member

LGTM but can you s/unused-result/-Wunused-result/ in the commit log?

@fhinkel
Copy link
Member

fhinkel commented Sep 9, 2016

LGTM

1 similar comment
@cjihrig
Copy link
Contributor

cjihrig commented Sep 9, 2016

LGTM

@santigimeno
src: fix -Wunused-result warning
cc00be6 
PR-URL: nodejs#8450
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@santigimeno santigimeno merged commit cc00be6 into nodejs:master Sep 9, 2016
@santigimeno
Copy link
Member Author

Landed in cc00be6 with commit log amended

@Fishrock123
Copy link
Contributor

Depends on #7082. Please mark these as dont-land-on-v6.x.

@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@santigimeno @jasnell @addaleax @Trott @bnoordhuis @fhinkel @cjihrig @Fishrock123 @nodejs-github-bot