Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix link on timers.md #8488

Closed
wants to merge 1 commit into from
Closed

doc: fix link on timers.md #8488

wants to merge 1 commit into from

Conversation

yorkie
Copy link
Contributor

@yorkie yorkie commented Sep 11, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Fix links on timers.md.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Sep 11, 2016
@Trott
Copy link
Member

Trott commented Sep 11, 2016

LGTM

3 similar comments
@cjihrig
Copy link
Contributor

cjihrig commented Sep 11, 2016

LGTM

@lpinca
Copy link
Member

lpinca commented Sep 11, 2016

LGTM

@addaleax
Copy link
Member

LGTM

@TimothyGu
Copy link
Member

LGTM.

@jasnell
Copy link
Member

jasnell commented Sep 12, 2016

LGTM

jasnell pushed a commit that referenced this pull request Sep 12, 2016
@yorkie @jasnell
doc: fix link on timers.md
ebaa69b 
PR-URL: #8488
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Sep 12, 2016

Landed in ebaa69b

@jasnell jasnell closed this Sep 12, 2016
@yorkie yorkie deleted the fix/timers-api-doc branch September 12, 2016 07:15
Fishrock123 pushed a commit that referenced this pull request Sep 14, 2016
@yorkie @Fishrock123
doc: fix link on timers.md
5387735 
PR-URL: #8488
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@yorkie @Trott @cjihrig @lpinca @addaleax @TimothyGu @jasnell @MylesBorins @nodejs-github-bot