-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix footer sizing #860
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduced to the minimal amount, any less shows a white bar.
Even if temporary, this is better than a giant grey box. |
so long as this works on pages that are |
Looks good to me. @Fishrock123 would you like to delimit the io.js links to a later pull request and have me merge this one? |
Fishrock123
added a commit
that referenced
this pull request
Feb 23, 2015
reduced to the minimal amount, any less shows a white bar. Semver: patch PR-URL: #860 Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
Merged in cb22bc9. Thanks! |
This was referenced Feb 23, 2015
This was referenced Nov 29, 2023
This was referenced Nov 30, 2023
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduced to the minimal amount, any less shows a white bar.
fixes nodejs/iojs.org#189
R=@chrisdickinson