internal: changed var to const in internal/v8_polyfill #8615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthewloring is this copied verbatim from in V8? If so we may not want to do this? |
|
@Fishrock123 I thought about that but since it is a polyfill and there is no comment about it I went ahead. If this is a copied verbatim we might want to add a comment in the file about that. |
|
These are not copied from V8. LGTM. |
|
why is there a "Copyright 2012 the V8 project authors." then ? |
|
The 2012 is an error. I believe I originally did the work in V8 and then moved it over to Node.js. Let me look back and double check. |
jasnell
pushed a commit
that referenced
this pull request
Sep 22, 2016
PR-URL: #8615 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 99f64f7. Thank you! |
jasnell
pushed a commit
that referenced
this pull request
Sep 29, 2016
PR-URL: #8615 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
PR-URL: #8615 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
internalDescription of change
Changed
vartoconst.Part of nodejs/code-and-learn#56