Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: changed var to const in internal/process/promises #8620

Closed
wants to merge 1 commit into from
Closed

process: changed var to const in internal/process/promises #8620

wants to merge 1 commit into from

Conversation

AdriVanHoudt
Copy link
Contributor

@AdriVanHoudt AdriVanHoudt commented Sep 17, 2016 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

process

Description of change

Changed var to const.
Part of nodejs/code-and-learn#56

cjihrig
cjihrig approved these changes Sep 17, 2016
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mscdex mscdex added the process Issues and PRs related to the process subsystem. label Sep 17, 2016
not-an-aardvark
not-an-aardvark approved these changes Sep 17, 2016
View reviewed changes
Copy link
Contributor

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

imyller
imyller approved these changes Sep 17, 2016
View reviewed changes
Copy link
Member

@imyller imyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

addaleax
addaleax approved these changes Sep 17, 2016
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the commit message should start with process:

@AdriVanHoudt AdriVanHoudt changed the title internal: changed var to const in internal/process/promises process: changed var to const in internal/process/promises Sep 18, 2016
@AdriVanHoudt
Copy link
Contributor Author

@addaleax changed

a0viedo
a0viedo approved these changes Sep 18, 2016
View reviewed changes
Copy link
Member

@a0viedo a0viedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JacksonTian
Copy link
Contributor

LGTM

@jasnell
Copy link
Member

jasnell commented Sep 20, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4164/

jasnell
jasnell approved these changes Sep 20, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

jasnell pushed a commit that referenced this pull request Sep 20, 2016
@AdriVanHoudt @jasnell
process: changed var to const in internal/process/promises
d4bf5ca 
PR-URL: #8620
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jackson Tian <shvyo1987@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member

jasnell commented Sep 20, 2016

Landed in d4bf5ca! thank you!

@jasnell jasnell closed this Sep 20, 2016
@AdriVanHoudt AdriVanHoudt deleted the const_promises branch September 21, 2016 07:14
@AdriVanHoudt
Copy link
Contributor Author

AdriVanHoudt commented Sep 21, 2016 •
edited
Loading

you're welcome!

Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@AdriVanHoudt @Fishrock123
process: changed var to const in internal/process/promises
e8f1cf1 
PR-URL: #8620
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jackson Tian <shvyo1987@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

@cjihrig cjihrig cjihrig approved these changes

@a0viedo a0viedo a0viedo approved these changes

@imyller imyller imyller approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@AdriVanHoudt @JacksonTian @jasnell @addaleax @imyller @a0viedo @cjihrig @not-an-aardvark @mscdex @MylesBorins