test: update test-child-process-recv-handle #8648
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
the
child_process
cjihrig
reviewed
Sep 18, 2016
| assert.equal(typeof handle, 'object'); // Also matches null, therefore... | ||
| assert.ok(handle); // also check that it's truthy. | ||
| assert.strictEqual(msg, 'two'); | ||
| assert.strictEqual(typeof handle, 'object'); // Also matches null, |
There was a problem hiding this comment.
Maybe to simplify we could combine this and the following assertion like assert.ok(handle !== null && typeof handle === 'object');
There was a problem hiding this comment.
Ah yes, that makes sense.
change var to const/let where appropriate use strictEqual instead of equal call toString on buffers in strictEqual asserts use common.mustCall on callbacks containing asserts
JonathanPrince
force-pushed
the
update_test-child-process-recv-handle
branch
from
e1c3fea
to
c5b75aa
Compare
jasnell
pushed a commit
that referenced
this pull request
Sep 20, 2016
change var to const/let where appropriate use strictEqual instead of equal call toString on buffers in strictEqual asserts use common.mustCall on callbacks containing asserts PR-URL: #8648 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
Landed in 66dbd9c! thank you! |
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
change var to const/let where appropriate use strictEqual instead of equal call toString on buffers in strictEqual asserts use common.mustCall on callbacks containing asserts PR-URL: #8648 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
change var to const/let where appropriate
use strictEqual instead of equal
call toString on buffers in strictEqual asserts
use common.mustCall on callbacks containing asserts