Edited BUILDING.md, removing broken workaround for case where python
#8763
Conversation
| @@ -27,22 +27,14 @@ On OS X, you will also need: | |||
| On FreeBSD and OpenBSD, you may also need: | |||
| * libexecinfo | |||
|
|
|||
| To build Node.js: | |||
| In order to build Node.js, the first listing of `python` in your path must | |||
There was a problem hiding this comment.
PATHenvironment variable
Maybe better? or just PATH
There was a problem hiding this comment.
Thanks, made the change to
PATHenvironment variable
|
This issue shows why simply passing the configure script to the Python 2 binary won't work. FYI, the way I got it to work was creating a temp directory, where I symlinked the python2 & python2-config to be called python & python-config, then temporarily prepended that to my PATH variable. |
christopherfujino
force-pushed
the
docs-edit
branch
2 times, most recently
from
902b147
to
cc26987
Compare
|
@nodejs/documentation |
| @@ -27,22 +27,14 @@ On OS X, you will also need: | |||
| On FreeBSD and OpenBSD, you may also need: | |||
| * libexecinfo | |||
|
|
|||
| To build Node.js: | |||
| In order to build Node.js, the first listing of `python` in your `PATH` | |||
| environment variable must point to the Python 2.6/2.7 binary. To build: | |||
There was a problem hiding this comment.
I don't think this text should replace To build Node.js:.
I'd rather see something like:
To build Node.js:
$ ./configure $ makeNote that the above requires that
pythonresolve to Python 2.6/2.7 and not a newer version.
There was a problem hiding this comment.
Okay thanks, I made this change.
python defaults to version 3.
christopherfujino
force-pushed
the
docs-edit
branch
from
cc26987
to
8ca4ec1
Compare
|
LGTM |
1 similar comment
|
LGTM |
|
LGTM |
| $ $PYTHON ./configure | ||
| $ make | ||
| ``` | ||
| Note that the above requires that `python` resolve to Python 2.6/2.7 and not a newer version. |
There was a problem hiding this comment.
Would this be better?
Note that the above requirespythonresolve to either Python 2.6 or 2.7 and not a newer version.
There was a problem hiding this comment.
Landing, but doing the 2.6/2.7 -> 2.6 or 2.7 per @thefourtheye's suggestion.
Updated BUILDING.md, removing workaround for Python conflicts that didn't work. PR-URL: nodejs#8763 Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: James M Snell <jasnell@gmail.com> Refs: nodejs#8763
|
Landed in 7f7502d |
Updated BUILDING.md, removing workaround for Python conflicts that didn't work. PR-URL: #8763 Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: James M Snell <jasnell@gmail.com> Refs: #8763
Updated BUILDING.md, removing workaround for Python conflicts that didn't work. PR-URL: #8763 Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: James M Snell <jasnell@gmail.com> Refs: #8763
Checklist
Affected core subsystem(s)
Description of change
Updated BUILDING.md, removing workaround for Python conflicts that didn't work.