test:replace indexOf, assert.equal, add mustCall #8766
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
reviewed
Sep 25, 2016
| @@ -40,9 +40,9 @@ fs.symlink(linkData, linkPath, function(err) { | |||
|
|
|||
| fs.readlink(linkPath, common.mustCall(function(err, destination) { | |||
| if (err) throw err; | |||
There was a problem hiding this comment.
All of the if (err) throw err; can be replaced by assert.ifError(err);.
|
LGTM (either with or without the |
|
LGTM with the |
thefourtheye
approved these changes
Sep 28, 2016
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Sep 28, 2016
replace indexOf with includes replace assert.equal with assert.strictEqual add common.mustCall replace throw error with assert.ifError PR-URL: nodejs#8766 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
|
Landed in 8cd2306 |
|
Just a minor nit, but I noticed a missing space between subsystem name and first part of the actual message. |
jasnell
pushed a commit
that referenced
this pull request
Sep 29, 2016
replace indexOf with includes replace assert.equal with assert.strictEqual add common.mustCall replace throw error with assert.ifError PR-URL: #8766 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
replace indexOf with includes replace assert.equal with assert.strictEqual add common.mustCall replace throw error with assert.ifError PR-URL: #8766 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
In test/parallel/test-fs-symlink.js:
Line 15: the use of o.indexOf() can be replaced with a usage of o.includes() which will make it more clear.
Line 43: the use of assert.equal() can be assert.strictEqual() instead
Line 28: the callback should be wrapped in common.mustCall() like in other instances of callbacks later in the file.