Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix title level at tls.md #8782

Closed
wants to merge 1 commit into from
Closed

Conversation

yorkie
Copy link
Contributor

@yorkie yorkie commented Sep 26, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc, tls

Description of change

The changed title should be included in the title Deprecated APIs in tls documentation.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Sep 26, 2016
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
Copy link
Member

jasnell commented Sep 27, 2016

I'm gonna go out on a limb and say this one is trivial enough not to wait the full 48 hours to land.

@Fishrock123
Copy link
Contributor

🚢

jasnell pushed a commit that referenced this pull request Sep 27, 2016
PR-URL: #8782
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@jasnell
Copy link
Member

jasnell commented Sep 27, 2016

Landed in 33aa953

@jasnell jasnell closed this Sep 27, 2016
@yorkie yorkie deleted the doc/fix-tls branch September 27, 2016 15:09
jasnell pushed a commit that referenced this pull request Sep 29, 2016
PR-URL: #8782
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
PR-URL: #8782
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants