-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade v8 to 4.1.0.17 #879
Conversation
Why not 4.1.0.17 ? |
@targos Edit: Figured it out, I might do this later tonight. |
Upgraded to v8 4.1.0.17 |
If this lands prior to getting 1.3.0 out then I'd like to hold off release for another day to get a nightly out and in the wild. So my vote would for this to be in 1.3.1 rather than landing in haste I think. |
@rvagg Agreed. Tangent: not to slight @Cangit's work but I'd be more comfortable if a TC member does dependency upgrades. The reviewer either has to review the diff very carefully or do the upgrade a second time to check if there are no untoward changes. In both cases, it's more work for what should be a rubber-stamp pull request. I can update the contributing guide if there is agreement. |
Can I suggest giving the responsibility to keep deps updated to a named TC member(?) or give the process some kind of structure to avoid deps not being updated for long periods of time as no one prioritize them over other kinds of work. Perhaps someone that can be able to check every dependency once a week or similar and do the update if necessary. |
My guess is that not even every TC member is suited to do this. Perhaps we should just have a list of people who "do the v8 upgrades"? |
Minor v8 bump, current version is 4.1.0.14
Ref:
https://github.com/v8/v8-git-mirror/releases/tag/4.1.0.15
https://github.com/v8/v8-git-mirror/releases/tag/4.1.0.16
https://github.com/v8/v8-git-mirror/releases/tag/4.1.0.17
Bumped to v8 version 4.1.0.17