addin test for _stream.writable finished state #8791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
Sep 27, 2016
|
|
||
| assert.strictEqual(writable._writableState.finished, false); | ||
|
|
||
| writable.end('testing finished state', () => { |
There was a problem hiding this comment.
The callback here should be wrapped in a common.mustCall() in order to validate that it really does get called.
mcollina
requested changes
Sep 27, 2016
|
|
||
| writable._write = (chunk, encoding, cb) => { | ||
| cb(); | ||
| }; |
There was a problem hiding this comment.
Can you please add an assert also here that finished is false?
|
Good job! cc @nodejs/streams |
|
Can you please update the commit message to follow our standards? |
|
The commit style guidelines are detailed here: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit :-) |
rvagg
force-pushed
the
master
branch
2 times, most recently
from
c133999
to
83c7a88
Compare
|
@mcollina ping |
|
Failures unrelated. This is good to go, I'm planning on merging tomorrow or Friday, if no one else has objections. |
cjihrig
reviewed
Oct 26, 2016
| const writable = new stream.Writable(); | ||
|
|
||
| writable._write = (chunk, encoding, cb) => { | ||
| // the state finished should start in false |
There was a problem hiding this comment.
Could you capitalize and punctuate the comment please.
cjihrig
approved these changes
Oct 26, 2016
|
Merged in f12338d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Issue related: #8686