Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: remove unused backlog argument #8877

Closed
wants to merge 1 commit into from
Closed

cluster: remove unused backlog argument #8877

wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Oct 1, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
  • cluster
Description of change

Removes an unused backlog argument.

CI: https://ci.nodejs.org/job/node-test-pull-request/4345/

EDIT: CI is green except for a flaky test.

@mscdex mscdex added the cluster Issues and PRs related to the cluster subsystem. label Oct 1, 2016
@fhinkel
Copy link
Member

fhinkel commented Oct 3, 2016

Thanks! Landed in 9eb6179.

@fhinkel fhinkel closed this Oct 3, 2016
fhinkel pushed a commit that referenced this pull request Oct 3, 2016
@mscdex @fhinkel
cluster: remove unused backlog argument
9eb6179 
PR-URL: #8877
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@mscdex mscdex deleted the cluster-remove-unused-arg branch October 3, 2016 14:37
jasnell pushed a commit that referenced this pull request Oct 6, 2016
@mscdex @jasnell
cluster: remove unused backlog argument
424e165 
PR-URL: #8877
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@mscdex @Fishrock123
cluster: remove unused backlog argument
3d3bce6 
PR-URL: #8877
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@santigimeno santigimeno santigimeno approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mscdex @fhinkel @bnoordhuis @santigimeno @cjihrig @MylesBorins