Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n support to Windows Installer, add de-de #888

Closed
wants to merge 2 commits into from
Closed

Add i18n support to Windows Installer, add de-de #888

wants to merge 2 commits into from

Conversation

fhemberger
Copy link
Contributor

Updated version of #852 (see this issue for discussions so far), without the VBScripts contained in the "Windows SDK Components for Windows Installer Developers".

To make this PR work, paths to WiSubStg.vbs and WiLangId.vbs have to be adjusted in nodemsi.wixproj to match the location of the Windows SDK on the build machines (should be C:\Program Files\Windows Kits\8.1\bin\x86 or x64).

UPDATE: The original PR has been removed by GitHub on my request after removing the two VBScript files from the build process.

@fhemberger
Copy link
Contributor Author

Ok, a short recap on what has been discussed so far in the old PR:

  • This PR is pending resolution of Translate installers for OS X and Windows #819.
  • As @piscisaureus pointed out, the license for wisubstg.vbs and wilangid.vbs did not (clearly) allow redistribution, so I removed the original PR.
  • Question is: Can this be cleanly merged at all, when both scripts require the local path of the Windows SDK?

@piscisaureus
Copy link
Contributor

@rvagg
Copy link
Member

rvagg commented Feb 22, 2015

@fhemberger can you rebase to the current v1.x and I'll produce a test build for people to try out

@fhemberger
Copy link
Contributor Author

@rvagg Ok, I just rebased it to latest v1.x … keeping fingers crossed

@rvagg
Copy link
Member

rvagg commented Feb 23, 2015

@fhemberger something's up with your branch, it's not reconciling very nicely, I'll try and cherry-pick yours to make a workable branch but you should see if you can sort it out, even if it means checking out a fresh branch from the latest v1.x and cherry-picking your commit into that and force pushing over this one.

@rvagg
Copy link
Member

rvagg commented Feb 23, 2015

@rvagg
Copy link
Member

rvagg commented Feb 23, 2015

screen shot 2015-02-23 at 1 06 20 am

I don't have a razor for this yak at the moment, any ideas? suggestions? this is win 2008 btw, not that this should make a difference.

@fhemberger
Copy link
Contributor Author

@rvagg, see my original post of this PR:

To make this PR work, paths to WiSubStg.vbs and WiLangId.vbs have to be adjusted in nodemsi.wixproj to match the location of the Windows SDK on the build machines (should be C:\Program Files\Windows Kits\8.1\bin\x86 or x64).

@fhemberger
Copy link
Contributor Author

Force-pushed branch again using latest v1.x

@rvagg
Copy link
Member

rvagg commented Feb 23, 2015

ok, well that's pushing me towards a -1 on this given the setup overhead, our inability to automate setup of windows build machines is enough of a problem as it is

perhaps we need to find a way to do some auto-discovery in vcbuild.bat like we do looking for the msvc version (well, used to do)

@piscisaureus
Copy link
Contributor

Maybe you could add an wix variable to make the path to WiStubStg.vbs configurable?
Then vcbuild.bat could inject the detected visual studio path, similar to the way $WixToolPath is injected

In general I really don't like the way multi-language support is pieced together. I don't know anything about wix localization, but is there no more straighforward way then extracting a transforms file from the build product and then patching it in place?

@fhemberger
Copy link
Contributor Author

Well, unfortunately, I'm no MSI expert either, so I looked it up in a book about Windows Installers. And that was the recommended way (you can also find the same approach described on some websites).

I would highly appreciate it, if someone with a deeper knowledge of the subject could review the installer creation process.

@mathiask88
Copy link
Contributor

@fhemberger Did you try cscript.exe "$(WindowsSDK80Path)bin\$(Platform)\WiSubStg.vbs"...? This works for my environment(Win8.1/VS13)

@piscisaureus I do only know, that this is common practice.

@fhemberger
Copy link
Contributor Author

@mathiask88 Works for me as well in Visual Studio 2013. I added it to the PR.

@rvagg Would you please be so kind and try your build again?

@mscdex mscdex added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Mar 22, 2015
@mathiask88
Copy link
Contributor

bumping this one. Maybe land in 2.0? My opinion is that if io.js is going for i18n the installer should stick to this plan even though everybody should be able to click some 'next' buttons but under the circumstance that this PR works reliable. I also think that there is not so much future work to do because the installer does not change that often and there will be always the fallback to English.

@fhemberger
Copy link
Contributor Author

Any news on the status of the Windows installer? cc @nodejs/platform-windows

@fhemberger
Copy link
Contributor Author

@rvagg Uhm. Should I create a new PR against master? If it makes it easier to land, I could comment out the German version for now and just make sure everything is in place (use variables instead of english texts) if we want to start adding translations.

@rvagg
Copy link
Member

rvagg commented Jul 25, 2015

@fhemberger perhaps, could you refresh us on the state of the requirements here, this still uses WiX right, do we need to install anything else to make this work?

@fhemberger
Copy link
Contributor Author

WiX and Windows SDK should be everything you need.

@rvagg
Copy link
Member

rvagg commented Jul 25, 2015

@fhemberger ok, do it against next and we'll see if we can squish it in to 3.0

@fhemberger
Copy link
Contributor Author

Ok, created a new PR against next in #2247, closing this.

@fhemberger fhemberger closed this Jul 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants