tls: handle error events with _tlsError
#8889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `TLSSocket#_emitTLSError` was used as an `error` event handler. However that function can emit `error` event itself, so it is not suitable for such use. Luckily the event can be emitted only when the control is released, so this looping-error can't happen. Replace the error handler for clarity and correctness.
fhinkel
approved these changes
Oct 3, 2016
cjihrig
approved these changes
Oct 3, 2016
|
Landed in d33c4bf, thank you! |
indutny
added a commit
that referenced
this pull request
Oct 3, 2016
Previously `TLSSocket#_emitTLSError` was used as an `error` event handler. However that function can emit `error` event itself, so it is not suitable for such use. Luckily the event can be emitted only when the control is released, so this looping-error can't happen. Replace the error handler for clarity and correctness. PR-URL: #8889 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 6, 2016
Previously `TLSSocket#_emitTLSError` was used as an `error` event handler. However that function can emit `error` event itself, so it is not suitable for such use. Luckily the event can be emitted only when the control is released, so this looping-error can't happen. Replace the error handler for clarity and correctness. PR-URL: #8889 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
@indutny lts? |
|
@thealphanerd unnecessary, thanks! |
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
Previously `TLSSocket#_emitTLSError` was used as an `error` event handler. However that function can emit `error` event itself, so it is not suitable for such use. Luckily the event can be emitted only when the control is released, so this looping-error can't happen. Replace the error handler for clarity and correctness. PR-URL: #8889 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
tls
Description of change
Previously
TLSSocket#_emitTLSErrorwas used as anerroreventhandler. However that function can emit
errorevent itself, so it isnot suitable for such use. Luckily the event can be emitted only when
the control is released, so this looping-error can't happen.
Replace the error handler for clarity and correctness.
cc @nodejs/crypto