deps: revert default gtest reporter change #8948

mscdex · 2016-10-06T05:45:14Z

Checklist

make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

gtest

Description of change

The default gtest reporter changed in c56ae16 from a pretty printing reporter to TAP. This caused TAP output to be displayed when running make test locally (outside of CI). This commit reverts that particular change.

/cc @bnoordhuis @jasnell

CI: https://ci.nodejs.org/job/node-test-pull-request/4405/

bnoordhuis · 2016-10-06T11:13:17Z

I made that change intentionally. Why would you want a different output format locally?

Fishrock123 · 2016-10-06T13:59:25Z

Can we leave the tap output for make test-ci and use the pretty one locally? There's not really a reason to have tap output in the local tests.

bnoordhuis · 2016-10-06T14:10:35Z

I think consistency with the CI is a pretty good reason. Libuv does the same thing; it makes visually comparing the output of local and remote runs a lot easier.

Fishrock123 · 2016-10-06T14:12:47Z

If you want CI output, just run make test-ci -- we aren't the same as Libuv. Do you want to change the JS test output too? If not, this should be reverted for local tests.

bnoordhuis · 2016-10-06T14:26:54Z

You asked for a reason and I gave you one. You are welcome to disagree but at least try to come up with a counterargument.

Fishrock123 · 2016-10-06T14:31:27Z

It's harder to read and also inconsistent.

bnoordhuis · 2016-10-06T14:40:29Z

Readability is subjective but I agree it's inconsistent. Then again, so is the normal gtest output vis-a-vis the JS test runner and the linters. It doesn't bother me personally but I'm okay with switching to TAP wholesale if you think consistency is important.

Fishrock123 · 2016-10-06T14:54:16Z

I'm not ok with that as it would mean scrolling through a few thousand lines of terminal text to find an error.

bnoordhuis

I'll -1 as a counterweight to your +1 because I don't think your readability and consistency arguments are convincing. Besides, I like the new format.

Fishrock123 · 2016-10-06T15:30:56Z

If you really want it, we can make make test-tap. It is far easier to do that than update all the docs references to point to some new make test-pretty for everyone new coming here.

addaleax

Yeah, I have to agree with @Fishrock123 and @mscdex here… being greeted by a tap Wall of Text doesn’t seem very helpful to me.

So, +1 to the revert here, although I realize that this is purely subjective from me, too.

jasnell · 2016-10-06T16:25:06Z

fwiw, I'm partial to the new formatting but will go with whatever the majority opinion is here. Perhaps rather than simply revert, this PR could add a test-tap target for those of us who prefer it.

mscdex · 2016-10-06T16:40:07Z

@jasnell Are you saying test-tap would output TAP just for cctest but use progress indicators/"pretty print" for all other tests (like it is before this PR), or?

jasnell · 2016-10-06T18:34:53Z

@mscdex... For now, test-tap would use the current behavior (before this revert). Eventually I'd like to see test-tap do the full output as TAP.

mscdex · 2016-10-06T21:25:56Z

Ok, I've added test-tap that uses a new flag to configure the default printed result format.

CI again: https://ci.nodejs.org/job/node-test-pull-request/4410/

gibfahn · 2016-10-07T11:07:19Z

It'd be really useful to have both TAP and pretty formats available for running tests, I frequently find myself using both.

Is it possible to have the gtest pretty format match the tools/test.py pretty format? Ideally you'd just have the one line for everything (assuming no failures).

thefourtheye · 2016-10-07T15:21:15Z

deps/gtest/src/gtest.cc

@@ -169,6 +169,9 @@ static const char kUniversalFilter[] = "*";
 // The default output file for XML output.
 static const char kDefaultOutputFile[] = "test_detail.xml";

+// The default result reporter format.
+static const char kDefaultResultFormat[] = "pretty";


thefourtheye · 2016-10-07T15:22:02Z

deps/gtest/src/gtest.cc

@@ -438,6 +446,17 @@ std::string UnitTestOptions::GetAbsolutePathToOutputFile() {
  return result.string();
 }

+// Functions for processing the gtest_result_format flag.


Isn't this supposed to be singular, Function?

I kept it that way for consistency in case more are added in the future. I see it as more of a list heading than a comment for the one function.

jasnell

LGTM with the nits raised by @thefourtheye addressed.

mscdex · 2016-10-10T20:58:36Z

@bnoordhuis Is this acceptable to you (make test-tap)?

bnoordhuis · 2016-10-11T18:41:30Z

If the choice is between no TAP output locally or carrying more patches on top of gtest, I'd rather go with the former.

bnoordhuis · 2016-10-17T16:16:43Z

@jbergstroem Did you ever make the change to make the CI pick up cctest.tap? Looking at e.g. https://ci.nodejs.org/job/node-test-commit-linux/5713/nodes=centos5-32/console I get the impression it doesn't currently.

jbergstroem · 2016-10-17T17:22:03Z

@bnoordhuis no, let me fix that now. Just very tedious working with jenkins jobs when its slow :'(

jbergstroem · 2016-10-17T17:54:15Z

@bnoordhuis just did a test run with aix61. Looks good -- do you agree? https://ci.nodejs.org/job/node-test-commit-aix/1508/

bnoordhuis · 2016-10-17T18:42:45Z

@jbergstroem Yes, looks good, thanks.

jbergstroem · 2016-10-17T19:44:55Z

@bnoordhuis cool. Will roll out the change now.

mscdex · 2016-10-23T07:56:48Z

CI once more before landing: https://ci.nodejs.org/job/node-test-pull-request/4626/

EDIT: CI is green except for a few flaky tests on freebsd and pi1.

PR-URL: nodejs#8948 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

PR-URL: #8948 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

PR-URL: nodejs#8948 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

PR-URL: #8948 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

mscdex added c++ Issues and PRs that require attention from people who are familiar with C++. tools Issues and PRs related to the tools directory. gtest labels Oct 6, 2016

nodejs-github-bot added the gtest label Oct 6, 2016

Fishrock123 approved these changes Oct 6, 2016

View reviewed changes

bnoordhuis requested changes Oct 6, 2016

View reviewed changes

addaleax approved these changes Oct 6, 2016

View reviewed changes

mscdex force-pushed the gtest-revert-default-reporter branch 2 times, most recently from 03824c8 to a205a9e Compare October 6, 2016 21:24

thefourtheye reviewed Oct 7, 2016

View reviewed changes

jasnell approved these changes Oct 7, 2016

View reviewed changes

mscdex force-pushed the gtest-revert-default-reporter branch from a205a9e to f9ad5da Compare October 7, 2016 18:12

mscdex force-pushed the gtest-revert-default-reporter branch from f9ad5da to cebefd4 Compare October 14, 2016 23:27

bnoordhuis approved these changes Oct 17, 2016

View reviewed changes

rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88 Compare October 18, 2016 17:02

mscdex force-pushed the gtest-revert-default-reporter branch from d12ed28 to cd3b53e Compare October 23, 2016 08:32

mscdex force-pushed the gtest-revert-default-reporter branch from cd3b53e to 6e5389e Compare October 23, 2016 08:34

mscdex closed this Oct 23, 2016

mscdex deleted the gtest-revert-default-reporter branch October 23, 2016 08:35

mscdex merged commit 6e5389e into nodejs:master Oct 23, 2016

mscdex mentioned this pull request Oct 24, 2016

build: run cctests as part of test-ci target #8034

Merged

MylesBorins added the lts-watch-v4.x label Oct 24, 2016

MylesBorins added the land-on-v6.x label Nov 14, 2016

MylesBorins added this to the 4.7.0 milestone Nov 14, 2016

mscdex mentioned this pull request Nov 18, 2016

backport: cctest TAP output changes #9682

Closed

2 tasks

MylesBorins added dont-land-on-v4.x and removed lts-watch-v4.x labels Nov 18, 2016

MylesBorins removed this from the 4.7.0 milestone Nov 22, 2016

This was referenced Nov 22, 2016

v6.9.2 proposal #9735

Merged

v4.7.0 proposal #9736

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: revert default gtest reporter change #8948

deps: revert default gtest reporter change #8948

mscdex commented Oct 6, 2016 •

edited

Loading

bnoordhuis commented Oct 6, 2016

Fishrock123 commented Oct 6, 2016 •

edited

Loading

bnoordhuis commented Oct 6, 2016

Fishrock123 commented Oct 6, 2016 •

edited

Loading

bnoordhuis commented Oct 6, 2016

Fishrock123 commented Oct 6, 2016

bnoordhuis commented Oct 6, 2016

Fishrock123 commented Oct 6, 2016 •

edited

Loading

bnoordhuis left a comment

Fishrock123 commented Oct 6, 2016 •

edited

Loading

addaleax left a comment

jasnell commented Oct 6, 2016

mscdex commented Oct 6, 2016

jasnell commented Oct 6, 2016

mscdex commented Oct 6, 2016 •

edited

Loading

gibfahn commented Oct 7, 2016

thefourtheye Oct 7, 2016

mscdex Oct 7, 2016

thefourtheye Oct 7, 2016

mscdex Oct 7, 2016

jasnell left a comment

mscdex commented Oct 10, 2016

bnoordhuis commented Oct 11, 2016

bnoordhuis commented Oct 17, 2016

jbergstroem commented Oct 17, 2016

jbergstroem commented Oct 17, 2016

bnoordhuis commented Oct 17, 2016

jbergstroem commented Oct 17, 2016

mscdex commented Oct 23, 2016 •

edited

Loading

deps: revert default gtest reporter change #8948

deps: revert default gtest reporter change #8948

Conversation

mscdex commented Oct 6, 2016 • edited Loading

Checklist

Affected core subsystem(s)

Description of change

bnoordhuis commented Oct 6, 2016

Fishrock123 commented Oct 6, 2016 • edited Loading

bnoordhuis commented Oct 6, 2016

Fishrock123 commented Oct 6, 2016 • edited Loading

bnoordhuis commented Oct 6, 2016

Fishrock123 commented Oct 6, 2016

bnoordhuis commented Oct 6, 2016

Fishrock123 commented Oct 6, 2016 • edited Loading

bnoordhuis left a comment

Choose a reason for hiding this comment

Fishrock123 commented Oct 6, 2016 • edited Loading

addaleax left a comment

Choose a reason for hiding this comment

jasnell commented Oct 6, 2016

mscdex commented Oct 6, 2016

jasnell commented Oct 6, 2016

mscdex commented Oct 6, 2016 • edited Loading

gibfahn commented Oct 7, 2016

thefourtheye Oct 7, 2016

Choose a reason for hiding this comment

mscdex Oct 7, 2016

Choose a reason for hiding this comment

thefourtheye Oct 7, 2016

Choose a reason for hiding this comment

mscdex Oct 7, 2016

Choose a reason for hiding this comment

jasnell left a comment

Choose a reason for hiding this comment

mscdex commented Oct 10, 2016

bnoordhuis commented Oct 11, 2016

bnoordhuis commented Oct 17, 2016

jbergstroem commented Oct 17, 2016

jbergstroem commented Oct 17, 2016

bnoordhuis commented Oct 17, 2016

jbergstroem commented Oct 17, 2016

mscdex commented Oct 23, 2016 • edited Loading

mscdex commented Oct 6, 2016 •

edited

Loading

Fishrock123 commented Oct 6, 2016 •

edited

Loading

Fishrock123 commented Oct 6, 2016 •

edited

Loading

Fishrock123 commented Oct 6, 2016 •

edited

Loading

Fishrock123 commented Oct 6, 2016 •

edited

Loading

mscdex commented Oct 6, 2016 •

edited

Loading

mscdex commented Oct 23, 2016 •

edited

Loading