Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: introduce secureContext for tls.connect #8959

Closed
wants to merge 1 commit into from
Closed

tls: introduce secureContext for tls.connect #8959

wants to merge 1 commit into from

Conversation

indutny
Copy link
Member

@indutny indutny commented Oct 6, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

tls

Description of change

Add secureContext option to tls.connect. It is useful for caching
client certificates, key, and CA certificates.

PR-URL: #4246
Reviewed-By: James M Snell jasnell@gmail.com

Backport of: #4246 (comment)

@nodejs-github-bot nodejs-github-bot added tls Issues and PRs related to the tls subsystem. v4.x labels Oct 6, 2016
@indutny
Copy link
Member Author

indutny commented Oct 6, 2016

cc @thealphanerd

@indutny
Copy link
Member Author

indutny commented Oct 6, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4408/

@MylesBorins MylesBorins added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 6, 2016
@MylesBorins MylesBorins self-assigned this Oct 6, 2016
jasnell
jasnell approved these changes Oct 6, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins MylesBorins force-pushed the v4.x-staging branch 2 times, most recently from 6a126fb to 004d665 Compare October 10, 2016 22:18
@indutny
Copy link
Member Author

indutny commented Oct 23, 2016

@thealphanerd should it be landed?

@jasnell
Copy link
Member

jasnell commented Oct 23, 2016

Looks like this needs to be rebased.

@MylesBorins MylesBorins added this to the v4.7.0 milestone Oct 24, 2016
@indutny
tls: introduce secureContext for tls.connect
125977b 
Add `secureContext` option to `tls.connect`. It is useful for caching
client certificates, key, and CA certificates.

PR-URL: nodejs#4246
Reviewed-By: James M Snell <jasnell@gmail.com>
@indutny indutny force-pushed the backport/c5b4f6bc996e25f9e24db8ed31df86010d2dfcec branch from 22d7fc6 to 125977b Compare October 24, 2016 18:38
@indutny
Copy link
Member Author

indutny commented Oct 24, 2016

@jasnell Voila! Though, there were no conflict 😉 This PR will become stale again unless we'll land it. cc @thealphanerd

@jasnell
Copy link
Member

jasnell commented Oct 26, 2016

I'm good for this to land.

@indutny
Copy link
Member Author

indutny commented Oct 27, 2016

@thealphanerd should I just land it? How does it work?

@MylesBorins
Copy link
Contributor

you can land it on staging 😊

@indutny
Copy link
Member Author

indutny commented Oct 27, 2016

Landed in d9b5437, thank you!

@indutny indutny closed this Oct 27, 2016
@indutny indutny deleted the backport/c5b4f6bc996e25f9e24db8ed31df86010d2dfcec branch October 27, 2016 00:55
@MylesBorins MylesBorins removed this from the 4.7.0 milestone Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees

@MylesBorins MylesBorins

Labels
semver-minor PRs that contain new features and should be released in the next minor version. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@indutny @jasnell @MylesBorins @nodejs-github-bot