Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: expand test coverage for url.js #8976

Closed
wants to merge 3 commits into from
Closed

test: expand test coverage for url.js #8976

wants to merge 3 commits into from

Commits on Oct 7, 2016

  1. test: expand test coverage for url.js 

    Currently Line 309 of lib/url.js is not reachable from test-url because there are no examples which has more than 255 characters in the hostname of the url.
I added one example which can reach that line.
    @jun-oka
    jun-oka committed Oct 7, 2016
    Configuration menu
    Copy the full SHA
    664d4d2 View commit details
    Browse the repository at this point in the history

  2. test: get rid of excessHostnameUrl const 

    delete excessHostnameUrl and add exceeded hostname url directly.
    @jun-oka
    jun-oka committed Oct 7, 2016
    Configuration menu
    Copy the full SHA
    8280e54 View commit details
    Browse the repository at this point in the history

  3. test: delete unnecessary empty line

    @jun-oka
    jun-oka committed Oct 7, 2016
    Configuration menu
    Copy the full SHA
    48c5474 View commit details
    Browse the repository at this point in the history