Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: response body in http module #8986

Closed
wants to merge 1 commit into from

Conversation

minervapanda
Copy link

@minervapanda minervapanda commented Oct 8, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

http

Description of change

Response body is omited when there is a HEAD request , 204 or 304 response. Solves #8057

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 8, 2016
@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Oct 8, 2016
@mscdex
Copy link
Contributor

mscdex commented Oct 8, 2016

The buffer and url doc changes should be in separate PRs.

@minervapanda
Copy link
Author

minervapanda commented Oct 9, 2016

@mscdex I am working on to make separate Pull Requests. I was facing problem having multiple request while I had other "open" pull requests. Now, I learnt it which is making different branch. I will do it.Though,I am thinking of sending fresh pull requests by closing all the present ones

doc: url.resolve() method behaviour
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants