-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: update outdated comment #8988
Conversation
from #8968 |
@@ -50,8 +50,8 @@ exports.fork = function(modulePath /*, args, options*/) { | |||
args = execArgv.concat([modulePath], args); | |||
|
|||
if (!Array.isArray(options.stdio)) { | |||
// Leave stdin open for the IPC channel. stdout and stderr should be the | |||
// same as the parent's if silent isn't set. | |||
// Use a separate fd=3 for IPC channel. Inherit stdin, stdout, and stderr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave "the" in front of "IPC channel".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Umm I have left out the 'the'
@cjihrig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I mean please leave it as it was. In other words, have it say "for the IPC channel."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh okay, thanks. It's done =)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jasnell, when will this commit be merged into |
PR-URL: #8988 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged! Landed in 835fbee! Thank you @Tanuja-Sawant ! |
PR-URL: #8988 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #8988 Reviewed-By: James M Snell <jasnell@gmail.com>
Checklist
Affected core subsystem(s)
comments
Description of change
Updated an outdated comment in child_process.js to describe the code better.