Make tests more clear #8999
Closed
Make tests more clear #8999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Oct 10, 2016
Trott
approved these changes
Oct 11, 2016
| const common = require('../common'); | ||
| const assert = require('assert'); | ||
| const path = require('path'); | ||
| const fs = require('fs'); | ||
|
|
||
| var filename = path.join(common.fixturesDir, 'does_not_exist.txt'); |
There was a problem hiding this comment.
Nit: Since you're in here already, can you make filename a constant too?
| const common = require('../common'); | ||
| const assert = require('assert'); | ||
| const path = require('path'); | ||
| const fs = require('fs'); | ||
|
|
||
| var filename = path.join(common.fixturesDir, 'does_not_exist.txt'); | ||
| fs.readFile(filename, 'latin1', common.mustCall(function(err, content) { |
There was a problem hiding this comment.
Nit: Can we add a line after assert.ok(err) like assert.strictEqual(err.code, 'ENOENT') or whatever the right error code is? I assume it will be the same across platform, but correction welcome.
| var path = require('path'); | ||
| var fs = require('fs'); | ||
| const path = require('path'); | ||
| const fs = require('fs'); | ||
|
|
||
|
|
||
| var filepath = path.join(common.tmpDir, 'write.txt'); |
There was a problem hiding this comment.
Nit: Can we make this filepath a constant too?
There was a problem hiding this comment.
Nit: I think the var in line 84 can also be a const, no?
There was a problem hiding this comment.
Nit: While we're in here refactoring anyway, maybe line 79 can be converted from assert.ok(err.message.indexOf('write after end') >= 0); to something more like assert.ok(err.message.includes('write after end'))?
|
LGTM if CI is OK. |
Add `assert.strictEqual(err.code, 'ENOENT')` and changed the last `var` to `const` for clarity
Refactor line 79 to use `includes()` instead of `indexOf() >= 0` for better readability. Change `var` to `const` for clarity
|
Thx for all the tips! @Trott |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 13, 2016
* var to const * add check that expected error is ENOENT * indexOf() to includes() PR-URL: nodejs#8999 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
|
Landed in a7970c0. Thanks! |
jasnell
pushed a commit
that referenced
this pull request
Oct 14, 2016
* var to const * add check that expected error is ENOENT * indexOf() to includes() PR-URL: #8999 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 11, 2016
* var to const * add check that expected error is ENOENT * indexOf() to includes() PR-URL: #8999 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
tests
Description of change
change 'var' to 'const' for clarity