Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: copy the Buffer object before using (backport to v4.x) #9016

Merged
merged 1 commit into from
Oct 11, 2016
Merged

tls: copy the Buffer object before using (backport to v4.x) #9016

merged 1 commit into from
Oct 11, 2016

Commits on Oct 11, 2016

  1. tls: copy the Buffer object before using 

    `convertNPNProtocols` and `convertALPNProtocols' uses the `protocols`
buffer object as it is, and if it is modified outside of core, it
might have an impact. This patch makes a copy of the buffer object,
before using it.

PR-URL: nodejs#8055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    @thefourtheye
    thefourtheye authored and Myles Borins committed Oct 11, 2016
    Configuration menu
    Copy the full SHA
    2847490 View commit details
    Browse the repository at this point in the history