util: use template literals #9120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
util
|
oh the linter was failing for a long line, gonna make that fix once CI finishes |
|
I'd be curious to see if this causes any performance regressions in util.format/util.inspect |
|
There should be no change in performance. AFAIK untagged template literals are desugared to string concatenation by V8's parser. |
This commit changes string manipulation in favor of template literals in the `util` module.
|
Fixed linter. |
rvagg
force-pushed
the
master
branch
2 times, most recently
from
c133999
to
83c7a88
Compare
targos
approved these changes
Oct 19, 2016
lpinca
approved these changes
Oct 24, 2016
|
New CI since the last one was aborted: https://ci.nodejs.org/job/node-test-pull-request/4637/ |
jasnell
pushed a commit
that referenced
this pull request
Oct 26, 2016
This commit changes string manipulation in favor of template literals in the `util` module. PR-URL: #9120 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 1ee36f6 |
evanlucas
pushed a commit
that referenced
this pull request
Nov 3, 2016
This commit changes string manipulation in favor of template literals in the `util` module. PR-URL: #9120 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 22, 2016
This commit changes string manipulation in favor of template literals in the `util` module. PR-URL: #9120 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 22, 2016
This commit changes string manipulation in favor of template literals in the `util` module. PR-URL: #9120 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Util
Description of change
This commit changes string manipulation in favor of template literals in the
utilmodule.