Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspector: fix request path nullptr dereference #9184

Merged
merged 2 commits into from
Oct 24, 2016
Merged

inspector: fix request path nullptr dereference #9184

merged 2 commits into from
Oct 24, 2016

Commits on Oct 24, 2016

  1. inspector: fix request path nullptr dereference 

    Fix a nullptr dereference when an invalid path is requested.

Regression introduced in commit 69fc85d ("inspector: generate UUID for
debug targets"), caught by Coverity.

PR-URL: nodejs#9184
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @bnoordhuis
    bnoordhuis committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    3d9b379 View commit details
    Browse the repository at this point in the history

  2. test: remove test-v8-inspector-json-protocol test 

    Remove parallel/test-v8-inspector-json-protocol, it duplicates the test
found in inspector/test-inspector.

PR-URL: nodejs#9184
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @bnoordhuis
    bnoordhuis committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    8e54c96 View commit details
    Browse the repository at this point in the history