Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix -Wunused-function warning #9220

Closed
wants to merge 1 commit into from
Closed

src: fix -Wunused-function warning #9220

wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

@bnoordhuis
src: fix -Wunused-function warning
7450fdc 
Fix the following compile-time warning:

    ../src/inspector_agent.cc:175:19: warning: 'const string
    node::inspector::{anonymous}::to_string(uint64_t)' defined but not
    used [-Wunused-function]
     const std::string to_string(uint64_t number) {

Refs: nodejs#8919
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 21, 2016
@mscdex mscdex added the inspector Issues and PRs related to the V8 inspector protocol label Oct 21, 2016
@bnoordhuis bnoordhuis mentioned this pull request Oct 23, 2016
Closed
2 tasks
@bnoordhuis
Copy link
Member Author

Closing, superseded by #9243.

@bnoordhuis bnoordhuis closed this Nov 18, 2016
@bnoordhuis bnoordhuis deleted the fix-unused-function-warning branch November 18, 2016 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bnoordhuis @jasnell @cjihrig @mscdex @nodejs-github-bot