Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make cross-context MakeCallback() calls work #9221

Merged
merged 1 commit into from
Oct 25, 2016
Merged

src: make cross-context MakeCallback() calls work #9221

merged 1 commit into from
Oct 25, 2016

Commits on Oct 25, 2016

  1. src: make cross-context MakeCallback() calls work 

    Check that invoking a callback on a receiver from a different context
works.

It ran afoul of an `env->context() == isolate->GetCurrentContext()`
assertion so retrieve the environment from the callback context and
the context to enter from the environment's context() method.

We could also have retrieved the environment from the receiver's context
and that would have made little practical difference.  It just seemed
more correct to get it from the callback context because that is the
actual execution context.

PR-URL: nodejs#9221
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @bnoordhuis
    bnoordhuis committed Oct 25, 2016
    Configuration menu
    Copy the full SHA
    921d2b0 View commit details
    Browse the repository at this point in the history