Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: clean up program/isolate/env init logic #9224

Merged
merged 2 commits into from
Oct 24, 2016
Merged

src: clean up program/isolate/env init logic #9224

merged 2 commits into from
Oct 24, 2016

Conversation

bnoordhuis
Copy link
Member

General cleanup:

  1. Shuffle around the startup sequence so it's less a ball of twine, and
  2. Remove the unnecessary NodeInstance class.

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 21, 2016
jasnell
jasnell approved these changes Oct 21, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@bnoordhuis
Copy link
Member Author

I started the CI yesterday but it doesn't show up. New run: https://ci.nodejs.org/job/node-test-pull-request/4618/

@jasnell
Copy link
Member

jasnell commented Oct 22, 2016

Some red there but they appear to be unrelated.

@bnoordhuis
src: simplify code, remove NodeInstanceData
d77e818 
NodeInstanceData is not used meaningfully and makes the initialization
logic harder to follow.  Let's remove it and delete 100 lines of code
in one fell swoop.

PR-URL: nodejs#9224
Reviewed-By: James M Snell <jasnell@gmail.com>
@bnoordhuis
src: clean up program/isolate/env init logic
ceb6023 
Reorder the initialization logic so that program-wide, per-isolate and
per-environment initialization is more cleanly separated.

PR-URL: nodejs#9224
Reviewed-By: James M Snell <jasnell@gmail.com>
@bnoordhuis bnoordhuis closed this Oct 24, 2016
@bnoordhuis bnoordhuis deleted the simplify-startup branch October 24, 2016 20:42
@bnoordhuis bnoordhuis merged commit ceb6023 into nodejs:master Oct 24, 2016
evanlucas pushed a commit that referenced this pull request Nov 2, 2016
@bnoordhuis @evanlucas
src: simplify code, remove NodeInstanceData
9e753ba 
NodeInstanceData is not used meaningfully and makes the initialization
logic harder to follow.  Let's remove it and delete 100 lines of code
in one fell swoop.

PR-URL: #9224
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Nov 2, 2016
@bnoordhuis @evanlucas
src: clean up program/isolate/env init logic
f2a3b24 
Reorder the initialization logic so that program-wide, per-isolate and
per-environment initialization is more cleanly separated.

PR-URL: #9224
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request Nov 3, 2016
Merged
@MylesBorins
Copy link
Contributor

@bnoordhuis should this be backported? I'm assuming it shouldn't land on v4. It does not land cleanly on v6. Please feel free to update labels

@bnoordhuis
Copy link
Member Author

Back-porting isn't necessary unless it causes conflicts for other pull requests. Let me know if that is the case.

@MylesBorins MylesBorins added the baking-for-lts PRs that need to wait before landing in a LTS release. label May 8, 2017
@MylesBorins MylesBorins removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnoordhuis @jasnell @MylesBorins @nodejs-github-bot