Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make test-crypto-timing-safe-equal-benchmarks more reliable #9241

Merged
merged 2 commits into from
Oct 24, 2016
Merged

test: make test-crypto-timing-safe-equal-benchmarks more reliable #9241

merged 2 commits into from
Oct 24, 2016

Commits on Oct 24, 2016

  1. test: move flaky test to test/pummel 

    Move sequential/test-crypto-timing-safe-equal-benchmarks to test/pummel
because it fails for me locally quite frequently and because it takes
about five or six seconds to complete, which is too long for a test in
test/sequential.

Fixes: nodejs#8744
PR-URL: nodejs#9241
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: not-an-aardvark <not-an-aardvark@users.noreply.github.com>
    @bnoordhuis
    bnoordhuis committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    1b8fca1 View commit details
    Browse the repository at this point in the history

  2. test: make flaky pummel test more reliable 

    Increase the number of iterations from 1e4 to 1e5.  Makes the test pass
for me locally when previously it would fail 9 out of 10 times because
the running time was not enough to smooth away the outliers.

Fixes: nodejs#8744
PR-URL: nodejs#9241
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: not-an-aardvark <not-an-aardvark@users.noreply.github.com>
    @bnoordhuis
    bnoordhuis committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    d1f7c96 View commit details
    Browse the repository at this point in the history