Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: skip whatwg url parse tests when icu is missing #9246

Closed
wants to merge 2 commits into from
Closed

test: skip whatwg url parse tests when icu is missing #9246

wants to merge 2 commits into from

Commits on Oct 24, 2016

  1. test: add common.hasIntl

    @jasnell
    jasnell committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    f4ce7c1 View commit details
    Browse the repository at this point in the history

  2. test: skip whatwg url parse and setter tests when icu is missing 

    the WHATWG url parser relies on ICU's punycode implementation.
A handful of the standard tests fail when ICU is not present
because of the additional checks that are not implemented. For
now, skip the parse and setter tests if ICU is not present.
    @jasnell
    jasnell committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    99cd46d View commit details
    Browse the repository at this point in the history