Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: make --repeat work with -j in test.py #9249

Closed
wants to merge 1 commit into from
Closed

tools: make --repeat work with -j in test.py #9249

wants to merge 1 commit into from

Commits on Oct 24, 2016

  1. tools: make --repeat work with -j in test.py 

    The repeat option in test.py did not work as expected if `-j` was set to
more than one. Repeated tests running at the same time could share temp
directories and cause test failures. This was observed with:

    tools/test.py -J --repeat=10 parallel/test-fs-watch-recursive

By using copy.deepCopy(), the repeated tests are separate objects and
not references to the same objects. Setting `thread_id` on one of them
will now not change the `thread_id` on all of them. And `thread_id` is
how the temp directory (and common.PORT as well) are determined.

Refs: nodejs#9228
    @Trott
    Trott committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    d60f00a View commit details
    Browse the repository at this point in the history