-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cares: sync with upstream, fully adopt v1.12.0 #9332
Conversation
@indutny @bnoordhuis I think you two might be best equipped to review this one |
@rvagg @richardlau should the AIX header be updated, too, or is it just cosmetic? |
cc/ @nodejs/platform-aix |
Looking at the changes to the @rvagg Looks like this change also adds |
updated license-builder.sh, thanks @richardlau, that's why I included LICENSE.md after all! |
I've updated AIX config, I had trouble getting access to an AIX machine yesterday but I've figured out my problem. PTAL IBMers. |
PR-URL: nodejs#5090 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Ping... updates? |
cc/ @nodejs/platform-aix regarding the AIX header update. |
@rvagg Any idea if the CI failures are related? Is this ready to land? |
c-ares 1.13.0 is available now. If we can land that instead, that will also take care of #13897 in the process. |
Is there any ETA on this? |
@rvagg are you going to follow up on this? |
Closing this due to a long inactivity. Please feel free to reopen if you want to follow up on this @rvagg |
Not a big change but previous sync's have been piecemeal so this is a full job. I've also redone most of the config headers in config/ (haven't touched the AIX one but it still compiles and passes).
Passing CI @ https://ci.nodejs.org/job/node-test-commit/5830/ minus unrelated freebsd failures.
I believe this is ABI and API stable so could be backported through to v4.x.