Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

constants: errors -> errno #9349

Closed
wants to merge 1 commit into from
Closed

constants: errors -> errno #9349

wants to merge 1 commit into from

Conversation

bengl
Copy link
Member

@bengl bengl commented Oct 28, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

constants

Description of change

lib/constants.js was incorrectly copying the constants from the
binding, by copying from contants.os.errors instead of
constants.os.errno.

@bengl
constants: errors -> errno
8134c62 
lib/constants.js was incorrectly copying the constants from the
binding, by copying from `contants.os.errors` instead of
`constants.os.errno`.
@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Oct 28, 2016
@mscdex mscdex added os Issues and PRs related to the os subsystem. constants and removed lib / src Issues and PRs related to general changes in the lib or src directory. labels Oct 29, 2016
jasnell
jasnell approved these changes Oct 29, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, ha! good catch.

lpinca
lpinca reviewed Nov 1, 2016
View reviewed changes
test/parallel/test-constants.js

['os', 'fs', 'crypto'].forEach((l) => {
Object.keys(binding[l]).forEach((k) => {
if (typeof binding[l][k] === 'object') { //errno and signals
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny tiny nit: space after // in the comment.

@mscdex mscdex removed the constants label Nov 16, 2016
@italoacasas
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/4985/console

italoacasas pushed a commit that referenced this pull request Nov 29, 2016
@bengl @italoacasas
constants: errors -> errno
edb78aa 
lib/constants.js was incorrectly copying the constants from the
binding, by copying from `contants.os.errors` instead of
`constants.os.errno`.

PR-URL: #9349
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@italoacasas
Copy link
Contributor

Landed in: edb78aa

addaleax pushed a commit that referenced this pull request Dec 5, 2016
@bengl @addaleax
constants: errors -> errno
5c9aa18 
lib/constants.js was incorrectly copying the constants from the
binding, by copying from `contants.os.errors` instead of
`constants.os.errno`.

PR-URL: #9349
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@bengl @MylesBorins
constants: errors -> errno
166eea7 
lib/constants.js was incorrectly copying the constants from the
binding, by copying from `contants.os.errors` instead of
`constants.os.errno`.

PR-URL: #9349
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@bengl @MylesBorins
constants: errors -> errno
432564e 
lib/constants.js was incorrectly copying the constants from the
binding, by copying from `contants.os.errors` instead of
`constants.os.errno`.

PR-URL: #9349
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@princejwesley princejwesley princejwesley approved these changes

@lpinca lpinca lpinca approved these changes

@ronkorving ronkorving ronkorving approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
os Issues and PRs related to the os subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@bengl @italoacasas @jasnell @ronkorving @lpinca @princejwesley @cjihrig @mscdex @MylesBorins @nodejs-github-bot