test: increase test coverage for lib/zlib.js #9366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for constructor behavior and parameter validation. Remove condition check that cannot be triggered (nothing is greater than `Infinity`).
Trott
added
zlib
cjihrig
reviewed
Oct 30, 2016
| /^Error: Invalid chunk size: -Infinity$/ | ||
| ); | ||
|
|
||
| // Confrim that maximum chunk size cannot be exceeded because it is `Infinity`. |
cjihrig
reviewed
Oct 30, 2016
| ); | ||
|
|
||
| // Confrim that maximum chunk size cannot be exceeded because it is `Infinity`. | ||
| assert.deepEqual(zlib.constants.Z_MAX_CHUNK, Infinity); |
There was a problem hiding this comment.
Should this be strictEqual() instead?
|
LGTM with a couple nits. |
|
Nits addressed. Thanks. CI again: https://ci.nodejs.org/job/node-test-pull-request/4742/ |
jasnell
approved these changes
Oct 30, 2016
cjihrig
approved these changes
Oct 31, 2016
JungMinu
approved these changes
Nov 2, 2016
|
LGTM |
jasnell
approved these changes
Nov 2, 2016
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Nov 2, 2016
Add tests for constructor behavior and parameter validation. Remove condition check that cannot be triggered (nothing is greater than `Infinity`). PR-URL: nodejs#9366 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Lnaded in 3eea668 |
evanlucas
pushed a commit
that referenced
this pull request
Nov 3, 2016
Add tests for constructor behavior and parameter validation. Remove condition check that cannot be triggered (nothing is greater than `Infinity`). PR-URL: #9366 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport |
|
Updated label to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test zlib
Description of change
Add tests for constructor behavior and parameter validation. Remove condition check that cannot be triggered (nothing is greater than
Infinity).