build: prioritise --shared-X-Y over pkg-config #9368
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this on OSX which is a bit more liberal with pkg-config output, you can't properly build against shared libraries when using non-standard locations for library files and headers. Switching the order of checks so
--shared-X-libname
,--shared-X-includes
and--shared-X-libpath
, if explicitly passed to./configue
, take precedence over whateverpkg-config
gives you./R=@nodejs/build